Re: rmtree cleanup - Mailing list pgsql-patches

From Andrew Dunstan
Subject Re: rmtree cleanup
Date
Msg-id 41818FC5.8080101@dunslane.net
Whole thread Raw
In response to Re: rmtree cleanup  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches

Tom Lane wrote:

>Andrew Dunstan <andrew@dunslane.net> writes:
>
>
>>The attached patch cleans up src/port/dirmod.c::rmtree() a bit. It moves
>>the filename finding portion into its own function, and in that function
>>only scans the directory once instead of twice.
>>
>>
>
>Applied, along with some further hacking to reduce the #ifdef clutter
>by providing palloc substitute routines.
>

Nice. It's actually readable now :-)

>I checked it still works on
>Unix, would you check I didn't break the Windows cases?
>
>
>
>

Yes, it works. Thanks.

andrew

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_autovacuum vacuum cost variables patch v2
Next
From: Neil Conway
Date:
Subject: Re: transformExpr() refactor