fix for Makefile.shlib multiply defined target - Mailing list pgsql-patches

From Andrew Dunstan
Subject fix for Makefile.shlib multiply defined target
Date
Msg-id 4177E8F6.20505@dunslane.net
Whole thread Raw
Responses Re: fix for Makefile.shlib multiply defined target
List pgsql-patches
The attached patch fixes a problem with multiple target definitions that
give rise to warnings like this:

../../src/Makefile.shlib:327: warning: overriding commands for target `libtsearch2.a'
../../src/Makefile.shlib:262: warning: ignoring old commands for target `libtsearch2.a'

cheers

andrew


Index: src/Makefile.shlib
===================================================================
RCS file: /home/cvsmirror/pgsql/src/Makefile.shlib,v
retrieving revision 1.86
diff -c -r1.86 Makefile.shlib
*** src/Makefile.shlib    16 Oct 2004 03:26:43 -0000    1.86
--- src/Makefile.shlib    21 Oct 2004 15:55:12 -0000
***************
*** 220,229 ****
--- 220,231 ----
    shlib            = $(NAME)$(DLSUFFIX)
    # needed for /contrib modules, not sure why
    SHLIB_LINK        += -lpgport
+   haslibarule   = yes
  endif

  ifeq ($(PORTNAME), win32)
    shlib            = lib$(NAME)$(DLSUFFIX)
+   haslibarule   = yes
  endif

  ifeq ($(PORTNAME), beos)
***************
*** 257,262 ****
--- 259,265 ----
  MK_NO_LORDER := true
  endif

+ ifndef haslibarule
  lib$(NAME).a: $(OBJS)
  ifdef MK_NO_LORDER
      $(LINK.static) $@ $^
***************
*** 264,269 ****
--- 267,273 ----
      $(LINK.static) $@ `$(LORDER) $^ | tsort`
  endif
      $(RANLIB) $@
+ endif #haslibarule

  ifeq ($(enable_shared), yes)


pgsql-patches by date:

Previous
From: Karel Zak
Date:
Subject: 8.0-NLS: czech
Next
From: Andrew Dunstan
Date:
Subject: fix windows contrib compile warnings for redefined macros