Re: Log line prefix on win32 - Mailing list pgsql-hackers

From Andreas Pflug
Subject Re: Log line prefix on win32
Date
Msg-id 4166D0F8.50808@pse-consulting.de
Whole thread Raw
In response to Re: Log line prefix on win32  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> 
>>I was thinking of adding %z as an option to log_line prefix, so to get
>>the current output you would do '%t %z'.  I was not suggesting changing
>>the %Z passed to strftime if they ask for timezone.
> 
> 
> I think this is a bad idea, mainly because you couldn't easily get the
> same output.  It would be almost the same, except when you crossed a DST
> boundary in between the two calls to strftime; in which case you'd get a
> completely misleading result.
> 
> I believe that in the long run we will stop using the platform-specific
> strftime at all, and go over to using just our own code, which makes
> this not a permanent problem but just an artifact of the fact that we
> haven't completely finished the process of absorbing src/timezone/.
> So I'd rather not invent an API element simply because Windows' strftime
> sucks.

However tz is implemented, I'd like to see a log_line_prefix option 
which simply omits the TZ, which is noise for me.

Regards,
Andreas


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Log line prefix on win32
Next
From: Tom Lane
Date:
Subject: Re: Log line prefix on win32