Re: Clean up ancient test style - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Clean up ancient test style
Date
Msg-id 4165763.1607707375@sss.pgh.pa.us
Whole thread Raw
In response to Clean up ancient test style  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> Many older tests where written in a style like
>      SELECT '' AS two, i.* FROM INT2_TBL ...

> where the first column indicated the number of expected result rows.
> This has gotten increasingly out of date, as the test data fixtures
> have expanded, so a lot of these don't match anymore and are misleading. 
>   Moreover, this style isn't really necessary, since the psql output 
> already shows the number of result rows.  (Perhaps this was different at 
> some point?)

> I'm proposing to clean all this up by removing all those extra columns.

+1 for concept ... I didn't bother to check the patch in detail.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Rethinking plpgsql's assignment implementation
Next
From: Robert Haas
Date:
Subject: Re: pg_basebackup test coverage