Re: x86_64 configure problem - Mailing list pgsql-hackers

From Joe Conway
Subject Re: x86_64 configure problem
Date
Msg-id 4148A9BE.80705@joeconway.com
Whole thread Raw
In response to Re: x86_64 configure problem  (Gaetano Mendola <mendola@bigfoot.com>)
Responses Re: x86_64 configure problem  (Gaetano Mendola <mendola@bigfoot.com>)
Re: x86_64 configure problem  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Gaetano Mendola wrote:
> python -c "from distutils import *" > /dev/null 2>&1 || (echo "You need
> distutils installed"; exit 1)
>

Sorry for the delay -- things got busy around here all of a sudden.

Attached is a version of the patch with James Pye's distutils checking
code. Gaetano, please verify it works properly for you.

Although Peter was clearly not in favor of this, Gaetano and James both
are, and I don't feel strongly either way. So barring any other
objections I'll apply this in a day or so.

One procedural issue did occur to me regarding this kind of change. It
requires someone to run autoconf after applying -- how is that normally
handled?

Thanks,

Joe
Index: config/python.m4
===================================================================
RCS file: /cvsroot/pgsql-server/config/python.m4,v
retrieving revision 1.7
diff -c -r1.7 python.m4
*** config/python.m4    29 Nov 2003 19:51:17 -0000    1.7
--- config/python.m4    15 Sep 2004 20:34:47 -0000
***************
*** 21,31 ****
  # Determine the name of various directory of a given Python installation.
  AC_DEFUN([_PGAC_CHECK_PYTHON_DIRS],
  [AC_REQUIRE([PGAC_PATH_PYTHON])
  AC_MSG_CHECKING([Python installation directories])
  python_version=`${PYTHON} -c "import sys; print sys.version[[:3]]"`
  python_prefix=`${PYTHON} -c "import sys; print sys.prefix"`
  python_execprefix=`${PYTHON} -c "import sys; print sys.exec_prefix"`
! python_configdir="${python_execprefix}/lib/python${python_version}/config"
  python_includespec="-I${python_prefix}/include/python${python_version}"
  if test "$python_prefix" != "$python_execprefix"; then
    python_includespec="-I${python_execprefix}/include/python${python_version} $python_includespec"
--- 21,39 ----
  # Determine the name of various directory of a given Python installation.
  AC_DEFUN([_PGAC_CHECK_PYTHON_DIRS],
  [AC_REQUIRE([PGAC_PATH_PYTHON])
+ AC_MSG_CHECKING([for Python distutils module])
+ if "${PYTHON}" 2>&- -c 'import distutils'
+ then
+     AC_MSG_RESULT(yes)
+ else
+     AC_MSG_RESULT(no)
+     AC_MSG_ERROR([distutils module not found])
+ fi
  AC_MSG_CHECKING([Python installation directories])
  python_version=`${PYTHON} -c "import sys; print sys.version[[:3]]"`
  python_prefix=`${PYTHON} -c "import sys; print sys.prefix"`
  python_execprefix=`${PYTHON} -c "import sys; print sys.exec_prefix"`
! python_configdir=`${PYTHON} -c "from distutils.sysconfig import get_python_lib as f; import os; print
os.path.join(f(plat_specific=1,standard_lib=1),'config')"`
  python_includespec="-I${python_prefix}/include/python${python_version}"
  if test "$python_prefix" != "$python_execprefix"; then
    python_includespec="-I${python_execprefix}/include/python${python_version} $python_includespec"

pgsql-hackers by date:

Previous
From: "Simon Riggs"
Date:
Subject: Re: some PITR performance data with DBT-2
Next
From: Gaetano Mendola
Date:
Subject: Re: x86_64 configure problem