Re: log_filename_prefix --> log_filename + strftime() - Mailing list pgsql-patches

From Andreas Pflug
Subject Re: log_filename_prefix --> log_filename + strftime()
Date
Msg-id 41343CFE.4040509@pse-consulting.de
Whole thread Raw
In response to Re: log_filename_prefix --> log_filename + strftime()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane wrote:
> Andreas Pflug <pgadmin@pse-consulting.de> writes:
>
>>I don't have the time now to review the impact, but this might make
>>interpreting the log filename difficult or impossible, effectively
>>corrupting pg_logdir_ls.
>
>
> So if you want to use that, you use a format that it can cope with.

"you" is the backend, which should be able to interpret what it wrote.

> I don't see a problem.

Yes, you don't see a problem if the logfile can't be displayed on the
client, I know that. My primary intention for contributing *any* logfile
related stuff was to make it available through admin interfaces, and
this goal seems to get obstructed in any possible way.

Anybody volunteering to fix the pg_logdir_ls code at
http://cvs.pgadmin.org/cgi-bin/viewcvs.cgi/pgadmin-tools/support/misc.c?rev=HEAD
  which should have been in the backend right from the start?

What about misbehaving size rotation if the filename isn't unique? And
what's a non human readable name.epoch pattern default good for?

Regards,
Andreas

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: log_filename_prefix --> log_filename + strftime()
Next
From: "Ed L."
Date:
Subject: Re: log_filename_prefix --> log_filename + strftime()