Re: [HACKERS] Binary Cursors, and the COPY command - Mailing list pgsql-jdbc

From Oliver Jowett
Subject Re: [HACKERS] Binary Cursors, and the COPY command
Date
Msg-id 41063FFE.8030400@opencloud.com
Whole thread Raw
In response to Re: [HACKERS] Binary Cursors, and the COPY command  (Oliver Jowett <oliver@opencloud.com>)
Responses Re: [HACKERS] Binary Cursors, and the COPY command
List pgsql-jdbc
Thomas Hallgren wrote:

> Well, the java.nio obviously :-)
>
> java.nio provides a java.nio.CharBuffer. A java.lang.StringBuffer is
> synchronized. The CharBuffer is not. Since the JDBC driver uses strings
> in a lot of places some code could be rewritten to increase performance.

I haven't seen the string manipulation to be much of a problem with the
current driver in the profiling I've done (it'll be quite application
specific though). And I'd have thought the stringbuffer monitors would
be essentially uncontended and cheap to enter. What are the hotspots you
see?

> And I think that Mark (pgsql@mohawksoft.com) has a point. 90% of all
> installations would get a performance boost if native byte order was
> used.

Well, not mine :) (x86 clients, sparc server, and the driver doesn't yet
use binary format in places where byte order matters anyway)

Also I am fairly suspicious about claims that native byte order will
make things go measurably faster. Do you have any profiling or
benchmarks to back that up? The low-level manipulation of protocol data
barely shows up on the profiles I've done.

-O

pgsql-jdbc by date:

Previous
From: Thomas Hallgren
Date:
Subject: Re: [HACKERS] Binary Cursors, and the COPY command
Next
From: Thomas Hallgren
Date:
Subject: Re: [HACKERS] Binary Cursors, and the COPY command