Re: Bug with view definitions? - Mailing list pgsql-hackers

From Andreas Pflug
Subject Re: Bug with view definitions?
Date
Msg-id 40EA65ED.7070402@pse-consulting.de
Whole thread Raw
In response to Re: Bug with view definitions?  (Andreas Pflug <pgadmin@pse-consulting.de>)
List pgsql-hackers
Andreas Pflug wrote:

> Christopher Kings-Lynne wrote:
>
>>>>  need_paren = (PRETTY_PAREN(context) ?
>>>>                                !IsA(op->rarg, RangeTblRef) : true);
>>>
>>>
>>>
>>>
>>> In a quick glance this code seems close to completely brain dead :-( 
>>

This probably was about catching
expr_A UNION (expr_B INTERSECT expr_C)
cases, falsely assuming left-to-right won't ever need parentheses.

Apparently the current version already fixes this completely, 
suppressing parentheses also with non-pretty.

Regards,
Andreas




pgsql-hackers by date:

Previous
From: "Zeugswetter Andreas SB SD"
Date:
Subject: Re: subtransactions and FETCH behaviour (was Re: PREPARE and transactions)
Next
From: Christopher Kings-Lynne
Date:
Subject: bug in DROP TABLESPACE