Re: APR 1.0 released - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: APR 1.0 released
Date
Msg-id 4052.24.211.141.25.1094699961.squirrel@www.dunslane.net
Whole thread Raw
In response to Re: APR 1.0 released  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: APR 1.0 released  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Bruce Momjian said:
> Andrew Dunstan wrote:
>>
>>
>> Reini Urban wrote:
>>
>> >
>> >
>> > FYI: WIN32 is also defined because <windows.h> is included.
>> > (/usr/incluse/w32api/windef.h)
>> > If you want this or that, do proper nesting, and use #else.
>> >
>> >
>>
>> Ugh, yes. A little experimentation shows that __WIN32__ is defined for
>>  MinGW only, but WIN32 is for both. I wonder how we missed that in
>> various places. Maybe we need a little audit of the use of WIN32.
>
> Done, and patch attached and applied.  Hopefully at least Cygwin will
> compile dirmod.c now.  (Most of the patch is consistency
> reorganization.)  We still need a review of that file.
>

I don't understand most of this patch. What difference does changing the
preprocessor test order make?


cheers

andrew




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: TRIGGER_DEFERRED_HAS_BEFORE ?
Next
From: Stephan Szabo
Date:
Subject: Re: Making AFTER triggers act properly in PL functions