Re: Startup message issues - Mailing list pgsql-jdbc

From Barry Lind
Subject Re: Startup message issues
Date
Msg-id 402D44B6.3060605@xythos.com
Whole thread Raw
In response to Startup message issues  ("Chris Smith" <cdsmith@twu.net>)
List pgsql-jdbc
Chris,

I will be the first to admit that the V3 protocol support is a hack (one
that I did :-( )  The intention was to get something quickly working (so
most of the code is just duplicated from the V2 code and then modified)
and then to go back later and refactor and cleanup.  Well that didn't
happen.  So I am really glad you are taking a stab at cleaning this up.

Specifically to your email, there is no reason that I can remember that
your assumptions are not valid.

thanks,
--Barry


Chris Smith wrote:
> Hope you don't mind the sudden questions.
>
> I'm working through the JDBC driver code.  The connection code really confuses
> me.  It seems like if we're speaking the V3 protocol successfully, we ought to
> be able to assume that the server is at least 7.4.  That would seem to remove
> a lot of the complexity of the open-connection code for v3 - namely, the
> client encoding stuff that contains backward-compatibility code all the way
> back to 7.1, and the 'show autocommit' that seems to have been an issue only
> for 7.3.  Assuming 7.4, I think we could jsut assume autocommit and set the
> client encoding to UNICODE in the startup message, and be done with it.
> Right?
>
> (Note: I don't actually know anything about the actual defaults and concerns
> here.  I'm getting my information from other code in the driver that makes
> these same assumptions that I'm proposing to make here.  If one of these
> assumptions is wrong, then it's the other code that needs to be fixed.)
>
> Comments?
>
> --
> www.designacourse.com
> The Easiest Way to Train Anyone... Anywhere.
>
> Chris Smith - Lead Software Developer/Technical Trainer
> MindIQ Corporation
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster


pgsql-jdbc by date:

Previous
From: Kris Jurka
Date:
Subject: Re: Unit tests
Next
From: "Chris Smith"
Date:
Subject: Re: Unit tests