Re: Add header support to text format and matching feature - Mailing list pgsql-hackers

Thanks for the feedback,

> There is one warning present in the changes:
> copy.c: In function ‘ProcessCopyOptions’:
> copy.c:1208:5: warning: ISO C90 forbids mixed declarations and code
> [-Wdeclaration-after-statement]
>     char    *sval = defGetString(defel);
>

Weirdly this is not caught by clang, even with -Wdeclaration-after-statement.

Here’s a new version that fix all the issues.

Rémi