Re: pgsql: Fix fat fingering in 22cb6d28950 - Mailing list pgsql-committers

On Fri, 11 Apr 2025 at 04:38, Andrew Dunstan <andrew@dunslane.net> wrote:
>
> Fix fat fingering in 22cb6d28950
>
> Per Rainier Vilela
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/39729ec01d25dbe12e0dd8322c68f242650235c9
>
> Modified Files
> --------------
> src/bin/pg_dump/pg_restore.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Hi,
This seems not a proper fix, rather this is adding a segfault.

Here, we are passing &q, but we can't free this by destroyStringInfo(&q); 

Fix: pg_free(q.data)

Quite right. Clearly I was not having a good day on Thursday. Will fix.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com