Re: pg_standby -l might destory the archived file - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: pg_standby -l might destory the archived file
Date
Msg-id 3f0b79eb0906011939x59d63cf7hbde1f55a5a03a5f4@mail.gmail.com
Whole thread Raw
In response to Re: pg_standby -l might destory the archived file  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pg_standby -l might destory the archived file  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
List pgsql-hackers
Hi,

On Tue, Jun 2, 2009 at 10:21 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Fujii Masao <masao.fujii@gmail.com> writes:
>> Yes, the old xlog itself is not used again. But, the *old file* might
>> be recycled and used later. The case that I'm looking at is that the
>> symlink to a temporary area is recycled. Am I missing something?
>
> Actually, I think the right fix for that would be to add defenses to
> xlog.c to not try to "recycle" a file that is a symlink.

OK, I tweaked Aidan's patch. Thanks Aidan!
http://archives.postgresql.org/message-id/20090601152736.GL15213@yugib.highrise.ca

Changes are:
- use lstat instead of stat
- add #if HAVE_WORKING_LINK and #endif code

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: It's June 1; do you know where your release is?
Next
From: Hiroshi Inoue
Date:
Subject: Re: [GENERAL] trouble with to_char('L')