Re: Signal handling patch (v2) for Synch Rep - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Signal handling patch (v2) for Synch Rep
Date
Msg-id 3f0b79eb0811152208t105be391k4cf8f397ef83d4b3@mail.gmail.com
Whole thread Raw
In response to Re: Signal handling patch (v2) for Synch Rep  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
List pgsql-hackers
On Sat, Nov 15, 2008 at 6:12 AM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
> Fujii Masao wrote:
>>
>> Attached is a patch of signal handling changes for Synch Rep.
>
> It seems that we wouldn't need to use the BackendPidGetProc function, nor
> the new AuxiliaryPidGetProc function, if we stored a PGPROC * instead of the
> pid in ProcState.procPid.

Sounds good! That can cut back on ProcArrayLock.

And, I add the code which deletes the request from WalSenderShmem
when the backend dies or aborts. I would call the delete function within
AbortTransaction(), and add it as a callback function (on_shmem_exit).

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


pgsql-hackers by date:

Previous
From: Andrew Chernow
Date:
Subject: Re: Compiling on HP-UX 10.20 fails
Next
From: "Jaime Casanova"
Date:
Subject: CVS can't be built on mingw