Re: Removing unneeded self joins - Mailing list pgsql-hackers

From Andrei Lepikhov
Subject Re: Removing unneeded self joins
Date
Msg-id 3c83675a-fdc5-4908-8584-fdc874f5fced@gmail.com
Whole thread Raw
In response to Re: Removing unneeded self joins  (Alexander Korotkov <aekorotkov@gmail.com>)
List pgsql-hackers
On 9/12/2024 13:03, Alexander Korotkov wrote:
> remove_self_join_rel().  Should we better add comments to PlannerInfo
> and other relevant structures saying: if you're going to modify this,
> consider how that affects remove_self_join_rel()?
> 
> Any thoughts?
As I see, it is quite typical to keep two parts of the code in sync by 
mentioning them in comments (see reparameterisation stuff, for example). 
This would reduce the code needed to implement the feature.

-- 
regards, Andrei Lepikhov




pgsql-hackers by date:

Previous
From: RECHTÉ Marc
Date:
Subject: Re: Logical replication timeout
Next
From: vignesh C
Date:
Subject: Re: Memory leak in pg_logical_slot_{get,peek}_changes