Re: Failed assertion on standby while shutdown - Mailing list pgsql-hackers

From Maxim Orlov
Subject Re: Failed assertion on standby while shutdown
Date
Msg-id 3c454bbe91f4ee67d9fc078926a72dc1@postgrespro.ru
Whole thread Raw
In response to Re: Failed assertion on standby while shutdown  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: Failed assertion on standby while shutdown
List pgsql-hackers
On 2021-04-01 15:02, Fujii Masao wrote:
> On 2021/03/31 19:51, Maxim Orlov wrote:
>> On 2021-03-30 20:44, Maxim Orlov wrote:
>>> The following review has been posted through the commitfest 
>>> application:
>>> make installcheck-world:  tested, passed
>>> Implements feature:       tested, passed
>>> Spec compliant:           not tested
>>> Documentation:            not tested
>>> 
>>> All the tests passed successfully.
>>> 
>>> The new status of this patch is: Ready for Committer
>> 
>> The patch is good. One note, should we put a comment about 
>> ShutdownRecoveryTransactionEnvironment not reentrant behaviour? Or 
>> maybe rename it to ShutdownRecoveryTransactionEnvironmentOnce?
> 
> +1 to add more comments into ShutdownRecoveryTransactionEnvironment().
> I did that. What about the attached patch?
> 
> Regards,

Well done! In my view is just what it's needed.

---
Best regards,
Maxim Orlov.



pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Replication slot stats misgivings
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Stronger safeguard for archive recovery not to miss data