Re: Failed assertion on standby while shutdown - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Failed assertion on standby while shutdown
Date
Msg-id ba2c75e0-22c1-2903-6cb3-18ebc107534d@oss.nttdata.com
Whole thread Raw
In response to Re: Failed assertion on standby while shutdown  (Maxim Orlov <m.orlov@postgrespro.ru>)
Responses Re: Failed assertion on standby while shutdown  (Maxim Orlov <m.orlov@postgrespro.ru>)
List pgsql-hackers

On 2021/03/31 19:51, Maxim Orlov wrote:
> On 2021-03-30 20:44, Maxim Orlov wrote:
>> The following review has been posted through the commitfest application:
>> make installcheck-world:  tested, passed
>> Implements feature:       tested, passed
>> Spec compliant:           not tested
>> Documentation:            not tested
>>
>> All the tests passed successfully.
>>
>> The new status of this patch is: Ready for Committer
> 
> The patch is good. One note, should we put a comment about ShutdownRecoveryTransactionEnvironment not reentrant
behaviour?Or maybe rename it to ShutdownRecoveryTransactionEnvironmentOnce?
 

+1 to add more comments into ShutdownRecoveryTransactionEnvironment().
I did that. What about the attached patch?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachment

pgsql-hackers by date:

Previous
From: yuzuko
Date:
Subject: Re: Autovacuum on partitioned table (autoanalyze)
Next
From: Greg Rychlewski
Date:
Subject: Re: DROP INDEX docs - explicit lock naming