Re: Minor refactorings to eliminate some static buffers - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Minor refactorings to eliminate some static buffers
Date
Msg-id 3b4e725d-710e-4d36-a8f8-b13e8ece3ba1@iki.fi
Whole thread Raw
In response to Re: Minor refactorings to eliminate some static buffers  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Minor refactorings to eliminate some static buffers
List pgsql-hackers
On 30/07/2024 18:44, Robert Haas wrote:
> On Tue, Jul 30, 2024 at 7:22 AM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>> As part of the multithreading work, it'd be nice to get rid of as many
>> global or static variables as possible. Remaining ones can be converted
>> to thread locals as appropriate, but where possible, it's better to just
>> get rid of them.
>>
>> Here are patches to get rid of a few static variables, by e.g.
>> converting them to regular local variables or palloc'd return values, as
>> appropriate.
>>
>> This doesn't move the needle much, but every little helps, and these
>> seem like nice little changes in any case.
> 
> I spent a few minutes looking through these patches and they seem like
> good cleanups. I couldn't think of a plausible reason why someone
> would object to any of these.

Committed, thanks for having a look.

-- 
Heikki Linnakangas
Neon (https://neon.tech)




pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: tiny step toward threading: reduce dependence on setlocale()
Next
From: Jeff Davis
Date:
Subject: [17+] check after second call to pg_strnxfrm is too strict, relax it