Re: Non-decimal integer literals - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Non-decimal integer literals
Date
Msg-id 3a3cc5e5-3d70-cdb9-f7a3-139d7d8742b9@enterprisedb.com
Whole thread Raw
In response to Re: Non-decimal integer literals  (Zhihong Yu <zyu@yugabyte.com>)
List pgsql-hackers
On 25.11.21 16:46, Zhihong Yu wrote:
> For patch 3,
> 
> +int64
> +pg_strtoint64(const char *s)
> 
> How about naming the above function pg_scanint64()?
> pg_strtoint64xx() can be named pg_strtoint64() - this would align with 
> existing function:
> 
> pg_strtouint64(const char *str, char **endptr, int base)

That would be one way.  But the existing pg_strtointNN() functions are 
pretty widely used, so I would tend toward finding another name for the 
less used pg_strtouint64(), maybe pg_strtouint64x() ("extended").




pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: RecoveryInProgress() has critical side effects
Next
From: Robert Haas
Date:
Subject: Re: Update stale code comment in CheckpointerMain()