Re: [PATCH] avoid double scanning in function byteain - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCH] avoid double scanning in function byteain
Date
Msg-id 3a323a3a-e260-4da6-aab1-6ac23ea1884d@eisentraut.org
Whole thread Raw
In response to Re: [PATCH] avoid double scanning in function byteain  (Stepan Neretin <slpmcf@gmail.com>)
List pgsql-hackers
The relationship between patch 0001 and 0002 is unclear to me.  Are 
these incremental or alternatives?  The description doesn't make this clear.

Some of the changes in patch 0002 just appear to move code and comments 
around without changing anything substantial.  It's not clear why that 
is done, as it's not related to what the patch claims it does.

The main tests for the bytea type input formats are in 
src/test/regress/sql/strings.sql, so you should add any new tests there. 
  Maybe there are already enough tests there that you don't need any new 
ones.

Overall, I would consider the bytea "escaped" format kind of 
obsolescent.  But if you want to make it a bit faster with little other 
impact, why not.



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part
Next
From: Peter Geoghegan
Date:
Subject: GIN and hash index scans show "Index Searches: 1" for unsatisfiable quals, unlike nbtree and GiST