Re: update i386 spinlock for hyperthreading - Mailing list pgsql-patches

From Manfred Spraul
Subject Re: update i386 spinlock for hyperthreading
Date
Msg-id 3FEDFB64.8090104@colorfullife.com
Whole thread Raw
In response to Re: update i386 spinlock for hyperthreading  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane wrote:

>Anyway, I've committed your patch with some changes.
>
>
Thanks.

>BTW, I noticed a lot of concern in the Intel app notes about reserving
>64 or even 128 bytes for each spinlock to avoid cache line conflicts.
>That seems excessive to me (we use a lot of spinlocks for buffers), but
>perhaps it is worth looking into.
>
This recommendation usually ignored in the Linux kernel.  A few very hot
spinlocks have an exclusive cacheline, but most don't.

>>Is there an easy way find out which LWLock is contended?
>>
>>
>
>Not from oprofile output, as far as I can think.  I've suspected for
>some time that the BufMgrLock is a major bottleneck, but have no proof.
>
>
I'll try to write a patch that dumps the LWLock usage and ask mark to
run it.

--
    Manfred


pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: update i386 spinlock for hyperthreading
Next
From: Tom Lane
Date:
Subject: Re: fork/exec patch: pre-CreateProcess finalization