Re: Coding help - Mailing list pgsql-hackers

From Christopher Kings-Lynne
Subject Re: Coding help
Date
Msg-id 3FAEE892.1010408@familyhealth.com.au
Whole thread Raw
In response to Re: Coding help  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Coding help  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
>>| COMMENT ON LARGE OBJECT NumericOnly IS comment_text
>>  n->objname = makeList1(makeAConst($5));
> 
> 
> Forget the makeAConst step --- it's just wasted cycles.  In the
> execution routine, you can use code comparable to define.c's defGetInt64()
> to convert the Value node into a numeric OID, ie, either do intVal() or
> a call of oidin().

I thought the whole problem here is that OIDs are unsigned ints, hence 
intVal() won't allow the highest OIDs?  If that's not the case, then the  easy solution is to just use an IConst or
whateverit's called. (Which 
 
I had working before).

Chris



pgsql-hackers by date:

Previous
From: Jan Wieck
Date:
Subject: Re: Performance features the 4th
Next
From: Tom Lane
Date:
Subject: Re: Coding help