> On 06 Sep 2017, at 08:42, Fabien COELHO <coelho@cri.ensmp.fr> wrote:
>
> Hello Alik,
>
> Applies, compiles, works for me.
>
> Some minor comments and suggestions.
>
> Two typos:
> - "usinng" -> "using"
> - "a rejection method used" -> "a rejection method is used"
>
> I'm not sure of "least_recently_used_i", this naming style is not used in pgbench. "least_recently_used" would be ok.
>
> "..nb_cells.. != ZIPF_CACHE_SIZE", ISTM that "<" is more logical,
> even if the result is the same?
>
> I would put the parameter value check in getZipfianRand, so that if someone reuse the function elsewhere the check is
alsoperformed. That would also simplify a bit the already very large expression evaluation function.
>
> When/if the pgbench tap test patch get through, coverage tests should
> be added.
>
> Maybe the cache overflow could be counted, to allow for a possible warning message in the final report?
Since this patch has been Waiting for author and no update on this patch has
been posted during the commitfest, it is Returned with feedback. When you have
a new version of the patch, please re-submit to a future commitfest.
cheers ./daniel
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
