Dave Page wrote:
>A couple of minor issues I found:
>
>- Casts do not live in a schema. They need to live alongside languages
>with the database as parent.
>
Done.
>- I don't see the pg_catalog schema no matter whether I have system
>objects on or off. I always see pg_temp_*.
>
Done. Ordered System/Temp/standard namespaces.
Please have a look at the properties and sql output of all objects. This
should be checked by somebody different from the code hacker, who's
normally blind... Maybe this task could be performed by somebody else?
Expecially weird cases with mixed namespaces for functions within one
object could be unhandled (missing schema) or "overhandled", i.e. shown
fully qualified while only legal within same namespace.Last pgAdmin3
version always available at
http://www.pse-consulting.de/pgadmin3/pgadmin3.zip
>- Keith's fix for the login loop doesn't work. If you get your password
>wrong, it never let's you renenter it. What used to happen was it called
>the login code again (the bit Keith commented out), but let you re-enter
>the password and other details if appropriate.
>
Done. Still, in OnCancel() cursor won't switch back to pointer; could be
nasty to find so it's postponed.Actually, without having gone into it,
seems to be a wxWindows fault.
>
>On a more general note, one og the most useful things in pga2 is the
>logging system. There is one in pga3 tied in with wxLog - can we start
>using it liberally please 'cos it's invaluable for support purposes.
>sysLogger::DoLog() shows what each level will do.
>
>
This needs some modification; sql is shown only for "debug" level. Do
you like all those "pgXxx created"?
pgadmin2's level seem to be what we need.
Regards,
Andreas