Re: pgsql-server/ ontrib/tablefunc/tablefunc.c rc/ ... - Mailing list pgsql-committers

From Joe Conway
Subject Re: pgsql-server/ ontrib/tablefunc/tablefunc.c rc/ ...
Date
Msg-id 3E6AABA8.3090609@joeconway.com
Whole thread Raw
In response to pgsql-server/ ontrib/tablefunc/tablefunc.c rc/ ...  (tgl@postgresql.org (Tom Lane))
Responses Re: pgsql-server/ ontrib/tablefunc/tablefunc.c rc/ ...
List pgsql-committers
Tom Lane wrote:
> Log message:
>     Revise tuplestore and nodeMaterial so that we don't have to read the
>     entire contents of the subplan into the tuplestore before we can return
>     any tuples.  Instead, the tuplestore holds what we've already read, and
>     we fetch additional rows from the subplan as needed.  Random access to
>     the previously-read rows works with the tuplestore, and doesn't affect
>     the state of the partially-read subplan.  This is a step towards fixing
>     the problems with cursors over complex queries --- we don't want to
>     stick in Materialize nodes if they'll prevent quick startup for a cursor.
>

So if I understand this correctly, tuplestore_donestoring() is not used
anymore (and doen't even exist)? Anything else changed in tuplestore
behavior? I have to update PL/R also for this.

Thanks,

Joe




pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql-server/ ontrib/tablefunc/tablefunc.c rc/ ...
Next
From: Tom Lane
Date:
Subject: Re: pgsql-server/ ontrib/tablefunc/tablefunc.c rc/ ...