Re: minor changes in psql's \encoding command - Mailing list pgsql-patches

From Weiping He
Subject Re: minor changes in psql's \encoding command
Date
Msg-id 3E17BF02.2040102@zhengmai.com.cn
Whole thread Raw
In response to Re: minor changes in psql's \encoding command  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane wrote:

>
> I'm a bit dissatisfied with this, as (a) it fails utterly with pre-7.3
> servers; (b) it fails if the server is in transaction-abort state;
> (c) it fails if the client is in the middle of a query cycle already;
> (d) it changes what had been an extremely cheap call into an extremely
> expensive one.  (I shudder to think of the implications for an app that
> calls it in an inner loop, as for example per-character during display
> of results.)
>
> This is quite a large change from the old behavior to support what seems
> an unusual corner case.  How many clients have need to change encoding
> on the fly?
>
> I'd prefer to just document that PQclientEncoding is untrustworthy if
> the client sets the encoding directly (rather than via PGCLIENTENCODING
> or PQsetClientEncoding), and similarly that psql's \encoding is not
> trustworthy if one goes behind its back.
>
>             regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster
>



emm, understood your concern. documentation it seems better.
let me see if there better way to solve our problem.

regards    laser


pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: minor changes in psql's \encoding command
Next
From: Tom Lane
Date:
Subject: Re: minor changes in psql's \encoding command