Error in chkpass.c (contrib area) with suggestion - Mailing list pgsql-bugs

From Sedlak Anton
Subject Error in chkpass.c (contrib area) with suggestion
Date
Msg-id 3DB52FB0.3060506@cce.cz
Whole thread Raw
Responses Re: Error in chkpass.c (contrib area) with suggestion  (Stephan Szabo <sszabo@megazone23.bigpanda.com>)
Re: Error in chkpass.c (contrib area) with suggestion  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-bugs
Because author is not responding I'm writing to you.
In contrib/chkpass.c there is no checking against NULL values on input,
thus if you call eg. raw(NULL) then postgresql always dies.
Although storing encrypted password are highly required this behavior
makes this extension module unusable.

To correct it one must add some checkin before any PG_GETARG_XXX in
chkpass.c:
Suggested type of code follows:
------------------------------------------------------------------
 if(PG_ARGISNULL(0)) PG_RETURN_NULL();
------------------------------------------------------------------

Best regards and let me know if this is acceptable

Sedlak Anton

pgsql-bugs by date:

Previous
From: Arne Woerner
Date:
Subject: 10 concurrent clients / pure insert SQL scripts (each 100000 lines)
Next
From: Stephan Szabo
Date:
Subject: Re: now() gives the time of the last commit, not the time it