Re: 7.2.3 fixes (was Re: Cause of missing pg_clog files) - Mailing list pgsql-hackers

From Joe Conway
Subject Re: 7.2.3 fixes (was Re: Cause of missing pg_clog files)
Date
Msg-id 3D986E28.60404@joeconway.com
Whole thread Raw
In response to Cause of missing pg_clog files  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> One thing I am undecided about: I am more than half tempted to put in
> the fix that makes us able to cope with mktime's broken-before-1970
> behavior in recent glibc versions (e.g., Red Hat 7.3).  This seems like
> a good idea considering that other Linux distros will surely be updating
> glibc soon too.  On the other hand, it's hard to call it a critical bug
> fix --- it ain't on a par with the vacuum/clog problem, for sure.  And
> the patch has received only limited testing (basically just whatever
> use 7.3beta1 has had).  On the third hand, the patch only does something
> if mktime() has already failed, so it's hard to see how it could make
> life worse even if it's buggy.
> 
> Any votes on whether to fix that or leave it alone in 7.2.3?  I need
> some input in the next few hours ...
> 

+1 for fixing it

Joe



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: 7.2.3 fixes (was Re: Cause of missing pg_clog files)
Next
From: Greg Copeland
Date:
Subject: Re: 7.2.3?