compiling client utils under win32 - current 7.3devel is broken - Mailing list pgsql-hackers

From Joe Conway
Subject compiling client utils under win32 - current 7.3devel is broken
Date
Msg-id 3D9232F7.9090001@joeconway.com
Whole thread Raw
Responses Re: compiling client utils under win32 - current 7.3devel is broken  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
I'm trying to get the client utilities to compile under win32/VS.net per 
http://developer.postgresql.org/docs/postgres/install-win32.html.

I was able to do this successfully using the 7.2.2 tarball, but using current 
7.3devel there are a number of minor issues (missing defines, adjustments to 
includes), and one more difficult item (at least so far). The latter is the 
use of gettimeofday in fe-connect.c:connectDBComplete for which there does not 
seem to be a good alternate under win32.

In connectDBComplete I see:

/* * Prepare to time calculations, if connect_timeout isn't zero. */
if (conn->connect_timeout != NULL)
{  remains.tv_sec = atoi(conn->connect_timeout);

so it seems that the connection timeout can only be specified to the nearest 
second. Given that, is there any reason not to use time() instead of 
gettimeofday()?

It looks like there is a great deal of complexity added to the function just 
to accommodate the fact that gettimeofday returns seconds and microseconds as 
distinct members of the result struct. I think switching this code to use 
time() would both simplify it, and make it win32 compatible.

Comments?

Joe




pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: CVS checkout errors
Next
From: Tom Lane
Date:
Subject: Re: Insert Performance