Re: tuptoaster.c must *not* use SnapshotAny - Mailing list pgsql-hackers

From Hiroshi Inoue
Subject Re: tuptoaster.c must *not* use SnapshotAny
Date
Msg-id 3C4780A0.F4C3022C@tpf.co.jp
Whole thread Raw
In response to Re: tuptoaster.c must *not* use SnapshotAny  (Jan Wieck <janwieck@yahoo.com>)
List pgsql-hackers
Tom Lane wrote:
> 
> Jan Wieck <janwieck@yahoo.com> writes:
> >     Originally I added SnapshotAny only to solve the problem that
> >     the lookup of the toast table happens  independant  from  the
> >     access  to  the  main  tuple, and that in fact the main tuple
> >     could have been deleted by the own transaction in between.
> 
> >     Would changing SnapshotAny  to  honor  HEAP_MOVED_*  fix  the
> >     problem?  If nothing else by now uses this snapshot, it could
> >     be done in place.
> 
> What I've done is add an additional snapshot class SnapshotToast
> that behaves that way.  There are a couple other uses of SnapshotAny
> that I didn't think I wanted to mess with.

AFAIR SnapshotAny was introduced for Foreign Key stuff.
SnapshotToast doesn't seem a proper solution to me but
7.2 should be released ASAP anyway.

regards,
Hiroshi Inoue


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: tuptoaster.c must *not* use SnapshotAny
Next
From: Tom Lane
Date:
Subject: Re: Bug in pg_dump/restore -o