Re: GETTIMEOFDAY_1ARG change - Mailing list pgsql-hackers

From Thomas Lockhart
Subject Re: GETTIMEOFDAY_1ARG change
Date
Msg-id 3C3B097B.E91AFFEB@fourpalms.org
Whole thread Raw
In response to GETTIMEOFDAY_1ARG change  (Ulrich Neumann<u_neumann@gne.de>)
Responses Re: GETTIMEOFDAY_1ARG change  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> i would like to add the following changes to the code so that postgres
> doesn´t have any problems if we compile it on machines that have
> gettimeofday with 1 ARG and therefore don´t need 'struct timezone xxx'
> I´m working on a System where timezone is defined in another way.

What system? How is timezone defined for that system? Is it something
completely new and different, or a variant which we already handle in
other places but not for this case?

...
> 2.postgres.c
> ResetUsage(void)
> {
> #ifndef GETTIMEOFDAY_1ARG
>         struct timezone tz;
> #endif
> 
>         getrusage(RUSAGE_SELF, &Save_r);
>         gettimeofday(&Save_t, &tz);
...

So what "one argument" does gettimeofday() have? Where does "tz" come
from if it is not defined here? Does it become a global variable? Where
is it declared?

afaik the nabstime.c usage of gettimeofday() has been in the PostgreSQL
code for quite a while, so I'm suprised that this is a problem on the
new mystery platform ;)
                   - Thomas


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Time as keyword
Next
From: Holger Krug
Date:
Subject: Re: Time as keyword