Re: pgsql/src backend/tcop/postgres.c include/misc ... - Mailing list pgsql-committers

From Hiroshi Inoue
Subject Re: pgsql/src backend/tcop/postgres.c include/misc ...
Date
Msg-id 3C3A3355.F64AE39F@tpf.co.jp
Whole thread Raw
In response to Re: pgsql/src backend/tcop/postgres.c include/misc ...  ("Hiroshi Inoue" <Inoue@tpf.co.jp>)
Responses Re: pgsql/src backend/tcop/postgres.c include/misc ...
List pgsql-committers
Tom Lane wrote:
>
> Hiroshi Inoue <Inoue@tpf.co.jp> writes:
> > I think the much more significant change is the following
> > one not the above one.
>
> Well, yes; the "above" change was just a last-gasp attempt to make the
> old scheme work, whereas the "following" change introduced the new
> scheme.

As far as I see, the introduction of the ImmediateInterruptOK
flag made HOLD/RESUME_INTERRUPTS scheme pretty meaningless.
Does 'die' interrupts still really need HOLD/RESUME_INTERRUPTS
scheme ? If 'die' interrupts are only for normal shutdown,
even LockWaitCancel() isn't needed.

regards,
Hiroshi Inoue

pgsql-committers by date:

Previous
From: momjian@postgresql.org
Date:
Subject: pgsql/contrib/mysql my2pg.pl
Next
From: Tom Lane
Date:
Subject: Re: pgsql/src backend/tcop/postgres.c include/misc ...