Re: More fixes for missing double quotes in the shell scripts - Mailing list pgsql-patches

From Justin
Subject Re: More fixes for missing double quotes in the shell scripts
Date
Msg-id 3BB2A0BA.CAE251C@postgresql.org
Whole thread Raw
In response to More fixes for missing double quotes in the shell scripts  (Justin Clift <justin@postgresql.org>)
List pgsql-patches
Heh Heh Heh

It's cool with me.

I'll resubmit patches tonight which don't go "over the top" in this way
then.

:)

Regards and best wishes,

Justin Clift


Tom Lane wrote:
>
> Justin <justin@postgresql.org> writes:
> > If there's really something fundamentally wrong with this idea, then
> > let's only do the necessary ones.
>
> No, nothing fundamentally wrong.  I just prefer to avoid unnecessary
> notational clutter.  Your approach of "let's quote *every* shell
> variable" is defensible but I find it a tad over-the-top.  Comes down
> to a judgment call about code legibility, I suppose.
>
>                         regards, tom lane

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: More fixes for missing double quotes in the shell scripts
Next
From: Tom Lane
Date:
Subject: Re: Problem with setlocale (found in libecpg) [accessing a