Re: More fixes for missing double quotes in the shell scripts - Mailing list pgsql-patches

From Tom Lane
Subject Re: More fixes for missing double quotes in the shell scripts
Date
Msg-id 15260.1001562194@sss.pgh.pa.us
Whole thread Raw
In response to Re: More fixes for missing double quotes in the shell scripts  (Justin <justin@postgresql.org>)
Responses Re: More fixes for missing double quotes in the shell scripts  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Justin <justin@postgresql.org> writes:
> If there's really something fundamentally wrong with this idea, then
> let's only do the necessary ones.

No, nothing fundamentally wrong.  I just prefer to avoid unnecessary
notational clutter.  Your approach of "let's quote *every* shell
variable" is defensible but I find it a tad over-the-top.  Comes down
to a judgment call about code legibility, I suppose.

            regards, tom lane

pgsql-patches by date:

Previous
From: Justin
Date:
Subject: Re: More fixes for missing double quotes in the shell scripts
Next
From: Justin
Date:
Subject: Re: More fixes for missing double quotes in the shell scripts