Re: Small TAP improvements - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: Small TAP improvements
Date
Msg-id 39c05f3f-9c7e-4411-b314-95c6a20f5543@www.fastmail.com
Whole thread Raw
In response to Small TAP improvements  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: Small TAP improvements
List pgsql-hackers
The comment atop config_data still mentions $option, but after the patch that's no longer a name used in the function.
(Ihave to admit that using @_ in the body of the function was a little bit confusing to me at first. Did you do that in
orderto allow multiple options to be passed?)
 

Also: if you give an option to pg_config, the output is not prefixed with the variable name. So you don't need to strip
the"SHAREDIR =" bit: there isn't any.  This is true even if you give multiple options:
 

schmee: master 0$ pg_config --sharedir --includedir
/home/alvherre/Code/pgsql-install/REL9_6_STABLE/share
/home/alvherre/Code/pgsql-install/REL9_6_STABLE/include



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: better page-level checksums
Next
From: Andrew Dunstan
Date:
Subject: Re: Small TAP improvements