Re: Small patch for memory leak in src/backend/catalog/pg_proc.c - Mailing list pgsql-patches

From Tom Lane
Subject Re: Small patch for memory leak in src/backend/catalog/pg_proc.c
Date
Msg-id 3971.960908761@sss.pgh.pa.us
Whole thread Raw
In response to Small patch for memory leak in src/backend/catalog/pg_proc.c  (Denis Perchine <dyp@perchine.com>)
Responses Re: Small patch for memory leak in src/backend/catalog/pg_proc.c  (Denis Perchine <dyp@perchine.com>)
List pgsql-patches
Denis Perchine <dyp@perchine.com> writes:
***************
*** 327,331 ****
--- 327,332 ----
          CatalogCloseIndices(Num_pg_proc_indices, idescs);
      }
      heap_close(rel, RowExclusiveLock);
+     heap_freetuple(tup);
      return tup->t_data->t_oid;
  }

Uh, you didn't notice that the tuple you just freed is still in use
on the next line?

Memory leaks like this are not worth worrying about because the memory
will be reclaimed at end of transaction --- maybe even sooner after
I improve the memory-context handling.

            regards, tom lane

pgsql-patches by date:

Previous
From: Denis Perchine
Date:
Subject: Small patch for memory leak in src/backend/catalog/pg_proc.c
Next
From: Denis Perchine
Date:
Subject: Re: Small patch for memory leak in src/backend/catalog/pg_proc.c