Re: change regexp_substr first argument make tests more easier to understand. - Mailing list pgsql-hackers

From Ilia Evdokimov
Subject Re: change regexp_substr first argument make tests more easier to understand.
Date
Msg-id 396935e9-f111-49a1-a5c7-eb91e5fcc714@tantorlabs.com
Whole thread Raw
In response to Re: change regexp_substr first argument make tests more easier to understand.  (jian he <jian.universality@gmail.com>)
List pgsql-hackers
Hi everybody

Current tests with regexp_instr() and regexp_substr()  with string 
'abcabcabc' are really unreadable and you would spend time to understand 
that happens in these tests and if they are really correct. I'd better 
change them into "abcdefghi" just like in query

     SELECT regexp_substr('abcdefghi', 'd.q') IS NULL AS t;

Regards

Ilia Evdokimov,
Tantor Labs LLC.






pgsql-hackers by date:

Previous
From: Bertrand Drouvot
Date:
Subject: Re: Historic snapshot doesn't track txns committed in BUILDING_SNAPSHOT state
Next
From: Hao Zhang
Date:
Subject: Why not align item size in dshash_table?