Re: Assert failure on running a completed portal again - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Assert failure on running a completed portal again
Date
Msg-id 3932492.1733768212@sss.pgh.pa.us
Whole thread Raw
In response to Re: Assert failure on running a completed portal again  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
I wrote:
> Yugo NAGATA <nagata@sraoss.co.jp> writes:
>> I guess planstate is removed due to the redundancy that this is included
>> in queryDesc. If so, I think we can also remove use_parallel_mode for the
>> same reason.  

> Certainly there's a bit of aesthetic judgment involved here.

After thinking awhile longer, I'm coming around to the idea that
you're right and it'd be better to get rid of ExecutePlan's
use_parallel_mode argument.  We clearly have to pass down count and
direction, and it's sensible to pass down operation, sendTuples,
and dest because ExecutorRun is involved with those to perform
dest-receiver startup and shutdown.  But ExecutorRun has no real
concern with the parallelism decision, so it seems better to unify
that logic in one place.

I'll make that change before pushing.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: WARNING: missing lock on database "postgres" (OID 5) @ TID (0,4)
Next
From: "Andrey M. Borodin"
Date:
Subject: Re: [PATCH] Add sortsupport for range types and btree_gist