Re: pgsql: Protect GIST logic that assumes penalty values can't be negative - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgsql: Protect GIST logic that assumes penalty values can't be negative
Date
Msg-id 3900.1306883519@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Protect GIST logic that assumes penalty values can't be negative  (Greg Stark <gsstark@mit.edu>)
Responses Re: pgsql: Protect GIST logic that assumes penalty values can't be negative  (Greg Stark <gsstark@mit.edu>)
List pgsql-hackers
Greg Stark <gsstark@mit.edu> writes:
> On Tue, May 31, 2011 at 2:54 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> �Prevent problems by clamping negative penalty values to
>> zero. �(Just to be really sure, I also made it force NaNs to zero.)

> Do gistchoose et al expect the triangle function to obey the triangle
> inequality?

Don't think so.

> If so isn't it possible treating NaNs as zero would fail
> that? I'm not sure there's any safe assumption for NaN

Well, leaving it as NaN is almost certain to not work desirably.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: pgsql: Protect GIST logic that assumes penalty values can't be negative
Next
From: Greg Stark
Date:
Subject: Re: pgsql: Protect GIST logic that assumes penalty values can't be negative