Re: [HACKERS] Multiline privileges in \z - Mailing list pgsql-patches

From Brendan Jurd
Subject Re: [HACKERS] Multiline privileges in \z
Date
Msg-id 37ed240d0805041505h336146b1tdcc7339a46952760@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Multiline privileges in \z  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sun, May 4, 2008 at 10:55 AM, Tom Lane  wrote:
> Andrew Dunstan  writes:
>  > Wouldn't this expression:
>  >       pg_catalog.array_to_string(c.relacl, chr(10))
>  > be better expressed as
>  >       pg_catalog.array_to_string(c.relacl, E'\n')
>
>  +1 ... it's minor, but knowing that ASCII LF is 10 is probably not
>  wired into too many people's brains anymore.  (Besides, some of us
>  remember it as octal 12, anyway...)
>

Fair enough.  I just wanted a non-messy way of saying "1 newline,
please", and I wasn't too sure whether backslash escapes were
considered kosher for internal queries.

But you're right, readability is important.  No objections to using
the escape syntax.

Please note that I used chr(10) in my \du attributes patch as well.

Cheers,
BJ

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: http://getfiregpg.org

iD8DBQFIHjNA5YBsbHkuyV0RAuNSAJ0ZDLxhHaPj4CBsBCILnxHy+5Jf5ACfQHMH
4XZxczc+YEow3AFdayn9fGs=
=+TSV
-----END PGP SIGNATURE-----

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_postmaster_reload_time() patch
Next
From: Andrew Dunstan
Date:
Subject: Re: Fix \dT enum in psql