Re: PATCH pass PGOPTIONS to pg_regress - Mailing list pgsql-hackers

From Ildar Musin
Subject Re: PATCH pass PGOPTIONS to pg_regress
Date
Msg-id 376f1047-93cb-311f-7178-117ad4881f4b@postgrespro.ru
Whole thread Raw
In response to PATCH pass PGOPTIONS to pg_regress  (Manuel Kniep <m.kniep@web.de>)
Responses Re: PATCH pass PGOPTIONS to pg_regress  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Hi Manuel,

On 29.05.2018 16:19, Manuel Kniep wrote:
> Hi,
>
> attached patch passes PGOPTIONS env variable to pg_regress in
> pgxs.mk
>
> This is especially useful when developing extensions for different
> postgres versions where some session_variables might or might not
> exists.
>
> Consider something like this in an extensions makefile:
>
> ifeq ($(shell test $(VERSION_NUM) -ge 90600; echo $$?),0) PGOPTIONS+=
> "--max_parallel_workers_per_gather=0" endif
>
> But also when there are many testfiles it might be convenient to
> align some session parameter globally In the Makefile.

Have you considered using EXTRA_REGRESS_OPTS variable in extension's
Makefile?

EXTRA_REGRESS_OPTS=--temp-config=$(top_srcdir)/$(subdir)/extra.conf

Here extra.conf is implied to be a file in extension's root directory 
which contains additional server options.
This would only work for `make check` though, not `make installcheck`.

-- 
Ildar Musin
i.musin@postgrespro.ru


pgsql-hackers by date:

Previous
From: Antonin Houska
Date:
Subject: Incorrect visibility test function assigned to snapshot
Next
From: "REIX, Tony"
Date:
Subject: PostgreSQL 11 beta1 on AIX 7.2 : 2 failures in 32bit mode