Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCHES] WAL: O_DIRECT and multipage-writer - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCHES] WAL: O_DIRECT and multipage-writer
Date
Msg-id 3763.1106668598@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCHES] WAL: O_DIRECT and multipage-writer  (ITAGAKI Takahiro <itagaki.takahiro@lab.ntt.co.jp>)
Responses Re: WAL: O_DIRECT and multipage-writer
List pgsql-hackers
Tree view 
ITAGAKI Takahiro <itagaki.takahiro@lab.ntt.co.jp> writes:
> I resend the patch with diff -c.

What does XLOG_EXTRA_BUFFERS accomplish?

Also, I'm worried that you broke something by not updating
Write->curridx immediately in XLogWrite.  There certainly isn't going
to be any measurable performance boost from keeping that in a local
variable, so why take any risk?

            regards, tom lane

pgsql-hackers by date:

Previous
From: "J Roy"
Date:
Subject: how to set password while loging into database
Next
From: Christopher Browne
Date:
Subject: Re: Goals for 8.1