Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] BUG: pg_stat_statements query normalization issues with combined queries - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] BUG: pg_stat_statements query normalization issues with combined queries
Date
Msg-id 3732.1484428729@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] BUG: pg_stat_statements query normalization issueswith combined queries  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: [HACKERS] BUG: pg_stat_statements query normalization issues withcombined queries  (Craig Ringer <craig.ringer@2ndquadrant.com>)
List pgsql-hackers
Tree view 
Fabien COELHO <coelho@cri.ensmp.fr> writes:
>> It ends up being about 30 fewer lines of code overall, despite there 
>> being four places that have to make ad-hoc RawStmt nodes.  On the whole 
>> I feel like this is cleaner,

> I agree: Better typing, more homogeneous code (PlannedStmt for all), 
> less ad-hoc checks to work around utility statements...

OK, pushed like that.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] Packages: Again
Next
From: Amit Kapila
Date:
Subject: Re: [HACKERS] Parallel Index Scans