Re: [PATCH] Logical decoding of TRUNCATE - Mailing list pgsql-hackers

Il 25/01/18 13:18, Petr Jelinek ha scritto:
> On 25/01/18 08:26, Thomas Munro wrote:
>> On Wed, Jan 24, 2018 at 6:47 AM, Marco Nenciarini
>> <marco.nenciarini@2ndquadrant.it> wrote:
>>> Version 16 attached.
>>
>> Hi Marco,
>>
>> FYI this version doesn't compile:
>>
>> worker.c: In function ‘apply_handle_truncate’:
>> worker.c:888:39: error: ‘cascade’ undeclared (first use in this function)
>>   relid = logicalrep_read_truncate(s, &cascade, &restart_seqs);
>>                                        ^
>>
>

Fixed.

> Indeed.
>
> We also found one more issue - the truncate done by logical replication
> worker is not logically logged which would break cascading.
>

Fixed.

> I expect Marco to send new version shortly with both of these fixed.
>
New patch v17 attached.

Regards,
Marco

--
Marco Nenciarini - 2ndQuadrant Italy
PostgreSQL Training, Services and Support
marco.nenciarini@2ndQuadrant.it | www.2ndQuadrant.it