Re: pg17.3 PQescapeIdentifier() ignores len - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg17.3 PQescapeIdentifier() ignores len
Date
Msg-id 3718761.1739473512@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg17.3 PQescapeIdentifier() ignores len  (Ranier Vilela <ranier.vf@gmail.com>)
Responses Re: pg17.3 PQescapeIdentifier() ignores len
List pgsql-hackers
Ranier Vilela <ranier.vf@gmail.com> writes:
> Interesting, Coverity has some new reports regarding PQescapeIdentifier.

> CID 1591290: (#1 of 1): Out-of-bounds access (OVERRUN)
> 2. alloc_strlen: Allocating insufficient memory for the terminating null of
> the string. [Note: The source code implementation of the function has been
> overridden by a builtin model.]

That's not new, we've been seeing those for awhile.  I've been
ignoring them on the grounds that (a) if the code actually had such a
problem, valgrind testing would have found it, and (b) the message is
saying in so many words that they're ignoring our code in favor of
somebody's apparently-inaccurate model of said code.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg17.3 PQescapeIdentifier() ignores len
Next
From: Pavel Stehule
Date:
Subject: Re: Is pgAdmin the only front-end to PostgreSQL debugger ? And is "a working pl/pgsql debugger" something core should care to maintain ?