[HACKERS] pgrowlocks relkind check - Mailing list pgsql-hackers

From Amit Langote
Subject [HACKERS] pgrowlocks relkind check
Date
Msg-id 370b6d10-24d1-fd17-c74b-f4e44fa052ea@lab.ntt.co.jp
Whole thread Raw
Responses Re: [HACKERS] pgrowlocks relkind check  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
The following commit added relkind checks to certain contrib modules so
that a more user-friendly error is produced if the wrong kind of relation
is passed to its functions:

commit c08d82f38ebf763b79bd43ae34b7310ee47aaacd
Author: Stephen Frost <sfrost@snowman.net>
Date:   Thu Mar 9 16:34:25 2017 -0500

    Add relkind checks to certain contrib modules

But it missed pgrowlocks, so the following happens:

create extension pgrowlocks;
create view one as select 1;
select pgrowlocks('one');
-- ERROR:  could not open file "base/68730/68748": No such file or directory

With the attached patch:

select pgrowlocks('one');
ERROR:  "one" is not a table, index, materialized view, sequence, or TOAST
table

Thanks,
Amit

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: [HACKERS] max_sync_workers_per_subscription is missing in postgresql.conf
Next
From: Magnus Hagander
Date:
Subject: Re: [HACKERS] [PATCH v1] Add and report the new "in_hot_standby" GUC pseudo-variable.