pg_walinspect float4/float8 confusion - Mailing list pgsql-hackers

From Peter Eisentraut
Subject pg_walinspect float4/float8 confusion
Date
Msg-id 36ee692b-232f-0484-ce94-dc39d82021ad@enterprisedb.com
Whole thread Raw
Responses Re: pg_walinspect float4/float8 confusion
List pgsql-hackers
The pg_walinspect function pg_get_wal_stats() has output arguments 
declared as float4 (count_percentage, record_size_percentage, etc.), but 
the internal computations are all done in type double.  Is there a 
reason why this is then converted to float4 for output?  It probably 
doesn't matter in practice, but it seems unnecessarily confusing.  Or at 
least add a comment so it doesn't look like an accident.  Also compare 
with pgstattuple, which uses float8 in its SQL interface for similar data.



pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Switching XLog source from archive to streaming when primary available
Next
From: Amit Langote
Date:
Subject: ATExecAddColumn() doesn't merge inherited properties