Busted includes somewhere near worker_internal.h - Mailing list pgsql-hackers

From Tom Lane
Subject Busted includes somewhere near worker_internal.h
Date
Msg-id 3699703.1595016554@sss.pgh.pa.us
Whole thread Raw
Responses Re: Busted includes somewhere near worker_internal.h  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
headerscheck and cpluspluscheck are both unhappy about this:

./src/include/replication/worker_internal.h:49:2: error: unknown type name 'slock_t'
  slock_t  relmutex;
  ^~~~~~~

Now, worker_internal.h itself hasn't changed in some time.
I conclude that somebody rearranged one of the header files
it depends on.  Anyone have an idea what the relevant change
was?  Should we just include spin.h here, or is there a
better fix?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Binary support for pgoutput plugin
Next
From: Andres Freund
Date:
Subject: Re: Busted includes somewhere near worker_internal.h