Re: [HACKERS] Time to change pg_regress diffs to unified by default? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Time to change pg_regress diffs to unified by default?
Date
Msg-id 3689.1546461889@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Time to change pg_regress diffs to unified by default?  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: [HACKERS] Time to change pg_regress diffs to unified by default?  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> While we're considering the pg_regress output, what do you think about
> replacing the ======... separator with a standard diff separator like
> "diff %s %s %s\n".  This would make the file behave more like a proper
> diff file, for use with other tools.  And it shows the diff options
> used, for clarity.  See attached patch.

I'm confused by this patch.  Doesn't moving the diff call like that
break the logic completely?

            regards, tom lane


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: psql display of foreign keys
Next
From: James Robinson
Date:
Subject: Arrays of domain returned to client as non-builtin oid describing thearray, not the base array type's oid