Re: [HACKERS] Time to change pg_regress diffs to unified by default? - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] Time to change pg_regress diffs to unified by default?
Date
Msg-id f619ac7d-9c56-7280-a094-fe204f7b58d7@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] Time to change pg_regress diffs to unified by default?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 02/01/2019 21:44, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> While we're considering the pg_regress output, what do you think about
>> replacing the ======... separator with a standard diff separator like
>> "diff %s %s %s\n".  This would make the file behave more like a proper
>> diff file, for use with other tools.  And it shows the diff options
>> used, for clarity.  See attached patch.
> 
> I'm confused by this patch.  Doesn't moving the diff call like that
> break the logic completely?

For clarification, I have attached a "before" and "after".

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: [HACKERS] Time to change pg_regress diffs to unified by default?
Next
From: Nikolay Shaplov
Date:
Subject: Re: [PATCH] check for ctags utility in make_ctags